[Asterisk-code-review] say.c: Fix file locations for second, seconds, minute, minut... (asterisk[14])

Rusty Newton asteriskteam at digium.com
Tue Jul 18 09:43:31 CDT 2017


Rusty Newton has posted comments on this change. ( https://gerrit.asterisk.org/6025 )

Change subject: say.c: Fix file locations for second, seconds, minute, minutes files
......................................................................


Patch Set 1:

> Should this include a note in UPGRADE.txt?

I'm not sure. It seems like a minor change. Say.c always had targets for these sounds in places they didn't exist by default, so it never worked. The modification just targets the files where they now exist.

I didn't move the files that already existed in the core package, which is the core supported package. Changes to the extra package should be inconsequential as nothing relies on those sounds.

 > Parts of say.c will no longer work with core sounds 1.5 + extra sounds 1.5.

Which parts will no longer work? Maybe I overlooked something?

>Can we also get an announcement of the new sounds versions to the same mailing lists that announce Asterisk upgrades?

I generally make an announcement on the lists when we release a new sounds version. I'll be sure to hit asterisk-announce as well as asterisk-users. I was also going to post on the blog.


-- 
To view, visit https://gerrit.asterisk.org/6025
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-MessageType: comment
Gerrit-Change-Id: I05d9d4bee6a7237030530a46e7eb3df15f13f702
Gerrit-Change-Number: 6025
Gerrit-PatchSet: 1
Gerrit-Owner: Rusty Newton <rnewton at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Rusty Newton <rnewton at digium.com>
Gerrit-Comment-Date: Tue, 18 Jul 2017 14:43:31 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170718/0a8089b3/attachment.html>


More information about the asterisk-code-review mailing list