[Asterisk-code-review] chan iax2: On reload make sure to check for existing MWI sub... (asterisk[14])

Joshua Colp asteriskteam at digium.com
Mon Jul 17 08:46:50 CDT 2017


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/6018 )

Change subject: chan_iax2: On reload make sure to check for existing MWI subscription
......................................................................

chan_iax2: On reload make sure to check for existing MWI subscription

On every reload of chan_iax2 module, MWI subscription was added, which
results in additional taskprocessors being accumulated over time.

This commit fixes it by making sure we check for existing subscription
first.

This was verified with 'core show taskprocessors' CLI command.

ASTERISK-27122 #close

Change-Id: Ie2ef528fd5ca01b933eeb88188cc10967899cfb9
---
M channels/chan_iax2.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Approved for Submit



diff --git a/channels/chan_iax2.c b/channels/chan_iax2.c
index 8941634..b056fcf 100644
--- a/channels/chan_iax2.c
+++ b/channels/chan_iax2.c
@@ -13064,7 +13064,7 @@
 		ast_free_acl_list(oldacl);
 	}
 
-	if (!ast_strlen_zero(peer->mailbox)) {
+	if (!ast_strlen_zero(peer->mailbox) && !peer->mwi_event_sub) {
 		struct stasis_topic *mailbox_specific_topic;
 
 		mailbox_specific_topic = ast_mwi_topic(peer->mailbox);

-- 
To view, visit https://gerrit.asterisk.org/6018
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2ef528fd5ca01b933eeb88188cc10967899cfb9
Gerrit-Change-Number: 6018
Gerrit-PatchSet: 1
Gerrit-Owner: Sergej Kasumovic <sergej at bicomsystems.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170717/83038748/attachment.html>


More information about the asterisk-code-review mailing list