[Asterisk-code-review] res pjsip: Add "webrtc" configuration option (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/5988 )

Change subject: res_pjsip: Add "webrtc" configuration option
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.asterisk.org/#/c/5988/5/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/#/c/5988/5/res/res_pjsip_sdp_rtp.c@1040
PS5, Line 1040: 		ast_copy_pj_str2(&session_media->msid, &attr->value);
> This is fine because it is dealing with address and not contents (after fre
Yes. The ast_copy_pj_str2 will allocate new memory, which session_media->msid will now point to. Its contents are freed before setting just in case it previously held a value. Otherwise a memory leak would occur.



-- 
To view, visit https://gerrit.asterisk.org/5988
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ec02e07c5d5b9ad86a34fdf31bf2f9da9aac6fd
Gerrit-Change-Number: 5988
Gerrit-PatchSet: 5
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 14 Jul 2017 16:12:27 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170714/e474924b/attachment.html>