[Asterisk-code-review] app confbridge: Make sure name recordings are always removed... (asterisk[13])

George Joseph asteriskteam at digium.com
Fri Jul 14 07:36:09 CDT 2017


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/6020 )

Change subject: app_confbridge: Make sure name recordings are always removed from the filesystem
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/6020/2/apps/app_confbridge.c
File apps/app_confbridge.c:

https://gerrit.asterisk.org/#/c/6020/2/apps/app_confbridge.c@2231
PS2, Line 2231: , async_delete_task_pushed = 0;
Even though there are many places in the code where we do multiple variable definitions on the same line, we've been trying to get away from that.  If you move this definition to its own line you should be good to go.



-- 
To view, visit https://gerrit.asterisk.org/6020
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I39b7271408b4b54ce880c5111a886aa8f28c2625
Gerrit-Change-Number: 6020
Gerrit-PatchSet: 2
Gerrit-Owner: Sergej Kasumovic <sergej at bicomsystems.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Fri, 14 Jul 2017 12:36:09 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170714/e436f578/attachment.html>


More information about the asterisk-code-review mailing list