[Asterisk-code-review] res rtp asterisk / res pjsip: Add support for BUNDLE. (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/5981 )

Change subject: res_rtp_asterisk / res_pjsip: Add support for BUNDLE.
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.asterisk.org/#/c/5981/2/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/#/c/5981/2/res/res_pjsip_sdp_rtp.c@1396
PS2, Line 1396: 		media->conn = bundle_group_stream->conn;
              : 		media->desc.port = bundle_group_stream->desc.port;
> The session media is marked as unbundled on an offer, so it'll use the abov
I don't quite understand, so Asterisk won't initially offer bundled streams?


https://gerrit.asterisk.org/#/c/5981/2/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/5981/2/res/res_pjsip_session.c@449
PS2, Line 449: 				session_media->mid = ast_strdup(ast_codec_media_type2str(type));
> It is, however I've found in order to have Firefox actually add the additio
Yes reusing the id's for an answer or a reinvite makes sense, but for a new offer originating from Asterisk each id needs to be unique. Or if a new stream is added to a group then that id needs to be unique.

I may be misreading the code, but it appears that setting the id here to something like "video" could cause to outgoing streams to be named "video"?


https://gerrit.asterisk.org/#/c/5981/2/res/res_pjsip_session.c@511
PS2, Line 511: 				/* The ordering of attributes determines our internal identification of the bundle group based on number,
             : 				 * with -1 being not in a bundle group. Since this is only exposed internally for response purposes it's
             : 				 * actually even fine if things move around.
             : 				 */
> Can you elaborate on this?
My mistake. I was thinking this was doing something else.



-- 
To view, visit https://gerrit.asterisk.org/5981
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96c0920b9f9aca7382256484765a239017973c11
Gerrit-Change-Number: 5981
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 12 Jul 2017 16:41:59 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170712/eaa5be33/attachment.html>