[Asterisk-code-review] chan pjsip: add a new function PJSIP DTMF MODE (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5909 )

Change subject: chan_pjsip: add a new function PJSIP_DTMF_MODE
......................................................................


Patch Set 12: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5909/12/channels/pjsip/dialplan_functions.c
File channels/pjsip/dialplan_functions.c:

https://gerrit.asterisk.org/#/c/5909/12/channels/pjsip/dialplan_functions.c@1211
PS12, Line 1211: 	if (channel->session->inv_session->state == PJSIP_INV_STATE_CONFIRMED) {
While it's reasonable to assume this is safe there's no guarantee on access like this. You have to do the check in the dispatched task.



-- 
To view, visit https://gerrit.asterisk.org/5909
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I20eef5da3e5d1d3e58b304416bc79683f87e7612
Gerrit-Change-Number: 5909
Gerrit-PatchSet: 12
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 12 Jul 2017 16:18:08 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170712/d0dda4ba/attachment-0001.html>