[Asterisk-code-review] bridge/core unreal: Fix SFU bugs with forwarding frames. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5994 )

Change subject: bridge/core_unreal: Fix SFU bugs with forwarding frames.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/5994/1/main/core_unreal.c
File main/core_unreal.c:

https://gerrit.asterisk.org/#/c/5994/1/main/core_unreal.c@326
PS1, Line 326: 	/* If we are told to write a frame with a type that has no corresponding
             : 	 * stream on the channel then drop it.
             : 	 */
             : 	if (f->frametype == AST_FRAME_VOICE) {
             : 		if (!ast_channel_get_default_stream(ast, AST_MEDIA_TYPE_AUDIO)) {
             : 			return 0;
             : 		}
             : 	} else if (f->frametype == AST_FRAME_VIDEO) {
             : 		if (!ast_channel_get_default_stream(ast, AST_MEDIA_TYPE_VIDEO)) {
             : 			return 0;
             : 		}
             : 	}
> Should this be handled down in the channel write instead of here?
I wrestled with this myself but I'm not sure I want to change it in the core yet unless we see other problems. It's only a problem here because there are two channels - and the frame ends up being read without a stream on the other.



-- 
To view, visit https://gerrit.asterisk.org/5994
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7445722c3219951d6740802a0feddf2908c18c8
Gerrit-Change-Number: 5994
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 12 Jul 2017 15:57:01 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170712/9a5a7035/attachment.html>