[Asterisk-code-review] res pjsip: Add "webrtc" configuration option (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5988 )

Change subject: res_pjsip: Add "webrtc" configuration option
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/5988/1/configs/samples/pjsip.conf.sample
File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/#/c/5988/1/configs/samples/pjsip.conf.sample@794
PS1, Line 794:          ; for webrtc: rtcp-mux, use_avpf, ice_support, and use_received_transport.
The option is "rtcp_mux"


https://gerrit.asterisk.org/#/c/5988/1/res/res_pjsip/pjsip_configuration.c
File res/res_pjsip/pjsip_configuration.c:

https://gerrit.asterisk.org/#/c/5988/1/res/res_pjsip/pjsip_configuration.c@1345
PS1, Line 1345: 		if (endpoint->media.rtp.encryption == AST_SIP_MEDIA_ENCRYPT_NONE) {
              : 			endpoint->media.rtp.encryption = AST_SIP_MEDIA_ENCRYPT_DTLS;
              : 			endpoint->media.rtp.dtls_cfg.enabled = 1;
              : 		}
              : 		if (endpoint->media.rtp.dtls_cfg.enabled) {
              : 			endpoint->media.rtp.dtls_cfg.default_setup = AST_RTP_DTLS_SETUP_ACTPASS;
              : 			if (endpoint->media.rtp.dtls_cfg.verify == AST_RTP_DTLS_VERIFY_NONE) {
              : 				endpoint->media.rtp.dtls_cfg.verify = AST_RTP_DTLS_VERIFY_FINGERPRINT;
              : 			}
              : 		}
Any reason to not just go ahead and explicitly set these regardless?


https://gerrit.asterisk.org/#/c/5988/1/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/5988/1/res/res_pjsip_session.c@3497
PS1, Line 3497: 		if (attr) {
              : 			pjmedia_sdp_attr_add(&local->attr_count, local->attr, attr);
              : 		}
Other places we assume the pool alloc is fine, as a result I think we can do the same here unless we want to audit everything else and make 'em consistent.



-- 
To view, visit https://gerrit.asterisk.org/5988
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ec02e07c5d5b9ad86a34fdf31bf2f9da9aac6fd
Gerrit-Change-Number: 5988
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 11 Jul 2017 14:59:01 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170711/b9a56c5f/attachment.html>