[Asterisk-code-review] res musiconhold: Add 'kill escalation delay option to classes (asterisk[master])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/5986 )

Change subject: res_musiconhold:  Add 'kill_escalation_delay option to classes
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5986/1/res/res_musiconhold.c
File res/res_musiconhold.c:

https://gerrit.asterisk.org/#/c/5986/1/res/res_musiconhold.c@696
PS1, Line 696: 	if (kill(pid, SIGTERM) < 0) {
As per our discussion on IRC, do you think we should make the behavior change (kill instead of killpg) a behavior we should hide behind an option?



-- 
To view, visit https://gerrit.asterisk.org/5986
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff70a1a9405685a9021a68416830c0db5158603b
Gerrit-Change-Number: 5986
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Comment-Date: Tue, 11 Jul 2017 14:24:17 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170711/04ce6103/attachment.html>