[Asterisk-code-review] http.c: Reduce log spam (asterisk[13])

George Joseph asteriskteam at digium.com
Thu Jul 6 08:00:52 CDT 2017


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/5962 )

Change subject: http.c:  Reduce log spam
......................................................................


Patch Set 1:

> Are there any legit errors from this that we would not want to hide
 > behind a debug message?

The only output from those WARNINGs I've ever seen have been client closes which are non-actionable.  At the point we fwrite to the socket, the only other error that could occur would have to be so catastrophic that the system would be unusable.  We don't even check the return from the fprintf of the headers, which I should probably fix now.


-- 
To view, visit https://gerrit.asterisk.org/5962
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I17bd5f3621514152a7b2b263c801324c5e96568b
Gerrit-Change-Number: 5962
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 06 Jul 2017 13:00:52 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170706/0f58a8d0/attachment.html>


More information about the asterisk-code-review mailing list