[Asterisk-code-review] http.c: Reduce log spam (asterisk[14])

George Joseph asteriskteam at digium.com
Wed Jul 5 15:33:57 CDT 2017


George Joseph has uploaded this change for review. ( https://gerrit.asterisk.org/5963


Change subject: http.c:  Reduce log spam
......................................................................

http.c:  Reduce log spam

Messages like "fwrite() failed: Connection reset by peer" are no
help whatsoever, especially since they can be caused simply by a
client disconnecting.

* Make those WARNINGs DEBUGs.

Change-Id: I17bd5f3621514152a7b2b263c801324c5e96568b
---
M main/http.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/63/5963/1

diff --git a/main/http.c b/main/http.c
index 907f102..9d585ae 100644
--- a/main/http.c
+++ b/main/http.c
@@ -531,7 +531,7 @@
 			 * behave exactly as documented.
 			 */
 			if (fwrite(ast_str_buffer(out), ast_str_strlen(out), 1, ser->f) != 1) {
-				ast_log(LOG_ERROR, "fwrite() failed: %s\n", strerror(errno));
+				ast_debug(1, "fwrite() failed: %s\n", strerror(errno));
 				close_connection = 1;
 			}
 		}
@@ -546,7 +546,7 @@
 				 * behave exactly as documented.
 				 */
 				if (fwrite(buf, len, 1, ser->f) != 1) {
-					ast_log(LOG_WARNING, "fwrite() failed: %s\n", strerror(errno));
+					ast_debug(1, "fwrite() failed: %s\n", strerror(errno));
 					close_connection = 1;
 					break;
 				}

-- 
To view, visit https://gerrit.asterisk.org/5963
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17bd5f3621514152a7b2b263c801324c5e96568b
Gerrit-Change-Number: 5963
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170705/1b236fce/attachment.html>


More information about the asterisk-code-review mailing list