[Asterisk-code-review] chan pjsip: send indication for a video refresh for h264 (asterisk[master])

Joshua Colp asteriskteam at digium.com
Wed Jul 5 05:16:52 CDT 2017


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5936 )

Change subject: chan_pjsip: send indication for a video refresh for h264
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5936/1/channels/chan_pjsip.c
File channels/chan_pjsip.c:

https://gerrit.asterisk.org/#/c/5936/1/channels/chan_pjsip.c@1602
PS1, Line 1602: 					ast_format_cap_iscompatible_format(ast_channel_nativeformats(ast), ast_format_h264) != AST_FORMAT_CMP_NOT_EQUAL) {
The ability to do this is negotiated within the SDP using the rtcp-fb attribute. If negotiated then we can use an RTCP FIR, otherwise we should fall back to the signaling based.



-- 
To view, visit https://gerrit.asterisk.org/5936
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96c4fe319442bf58c68f0dbbd25dae2f7b509b9
Gerrit-Change-Number: 5936
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 05 Jul 2017 10:16:52 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170705/0d267f0f/attachment.html>


More information about the asterisk-code-review mailing list