[Asterisk-code-review] pjsip distributor.c: Fix deadlock with TCP type transports. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5919 )

Change subject: pjsip_distributor.c: Fix deadlock with TCP type transports.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/5919/2/res/res_pjsip/pjsip_distributor.c
File res/res_pjsip/pjsip_distributor.c:

https://gerrit.asterisk.org/#/c/5919/2/res/res_pjsip/pjsip_distributor.c@356
PS2, Line 356: 		dlg = pjsip_ua_find_dialog(&rdata->msg_info.cid->id, local_tag,
> Why don't use pjsip_rdata_get_dlg?
Distribution happens before the transaction and user agent layer are invoked, as a result there is no dialog on the rdata so it has to be manually retrieved.



-- 
To view, visit https://gerrit.asterisk.org/5919
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ed63f4da9649e9db6ed4be29c360968917a89bd
Gerrit-Change-Number: 5919
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 04 Jul 2017 16:55:20 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170704/98d9230a/attachment.html>