[Asterisk-code-review] app queue: Fix queues randomly disappearing on reload (asterisk[master])

Kevin Harwell asteriskteam at digium.com
Thu Jan 26 18:17:37 CST 2017


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/4829 )

Change subject: app_queue: Fix queues randomly disappearing on reload
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/4829/1/apps/app_queue.c
File apps/app_queue.c:

PS1, Line 9264: 	/* Mark all queues as dead for the moment if we're reloading queues.
              : 	 * For clarity, we could just be reloading members, in which case we don't want to mess
              : 	 * with the other queue parameters at all*/
Minor nit: Update the comment to reflect the changes.


Line 9283: 	/* Unref all the dead queues if we were reloading queues */
Same here. Update the comment.


-- 
To view, visit https://gerrit.asterisk.org/4829
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a4537aec9eb8d8aeeaa0193407e3523feb004bf
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Kirill Katsnelson <kkm at smartaction.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list