[Asterisk-code-review] res pjsip endpoint identifier ip: Fix memory leak of hosts w... (asterisk[13])

Joshua Colp asteriskteam at digium.com
Thu Jan 26 07:59:12 CST 2017


Joshua Colp has uploaded a new change for review. ( https://gerrit.asterisk.org/4830 )

Change subject: res_pjsip_endpoint_identifier_ip: Fix memory leak of hosts when resolving.
......................................................................

res_pjsip_endpoint_identifier_ip: Fix memory leak of hosts when resolving.

This change adds a missing unreference of the hostname when resolving.

ASTERISK-26735

Change-Id: Ic012ebaf3d89e714eec340b7b0c5e63c66af857a
---
M res/res_pjsip_endpoint_identifier_ip.c
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/30/4830/1

diff --git a/res/res_pjsip_endpoint_identifier_ip.c b/res/res_pjsip_endpoint_identifier_ip.c
index c16e84a..5a3c3b0 100644
--- a/res/res_pjsip_endpoint_identifier_ip.c
+++ b/res/res_pjsip_endpoint_identifier_ip.c
@@ -323,8 +323,11 @@
 		} else if (results == -1) {
 			ast_log(LOG_ERROR, "An error occurred when adding resolution results of '%s' on '%s'\n",
 				current_string, ast_sorcery_object_get_id(obj));
+			ao2_ref(current_string, -1);
 			return -1;
 		}
+
+		ao2_ref(current_string, -1);
 	}
 
 	ao2_ref(identify->hosts, -1);

-- 
To view, visit https://gerrit.asterisk.org/4830
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic012ebaf3d89e714eec340b7b0c5e63c66af857a
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list