[Asterisk-code-review] chan oss.c: Fix format ref leak in oss read(). (asterisk[13])

Anonymous Coward asteriskteam at digium.com
Wed Jan 25 13:32:38 CST 2017


Anonymous Coward #1000019 has submitted this change and it was merged. ( https://gerrit.asterisk.org/4783 )

Change subject: chan_oss.c: Fix format ref leak in oss_read().
......................................................................


chan_oss.c: Fix format ref leak in oss_read().

Change-Id: I0a5d56c7dcf327d60f86a4c25a23571733709fd0
---
M channels/chan_oss.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Matthew Fredrickson: Looks good to me, approved
  Joshua Colp: Verified



diff --git a/channels/chan_oss.c b/channels/chan_oss.c
index 912a5eb..aa870df 100644
--- a/channels/chan_oss.c
+++ b/channels/chan_oss.c
@@ -727,7 +727,7 @@
 		return f;
 	/* ok we can build and deliver the frame to the caller */
 	f->frametype = AST_FRAME_VOICE;
-	f->subclass.format = ao2_bump(ast_format_slin);
+	f->subclass.format = ast_format_slin;
 	f->samples = FRAME_SIZE;
 	f->datalen = FRAME_SIZE * 2;
 	f->data.ptr = o->oss_read_buf + AST_FRIENDLY_OFFSET;

-- 
To view, visit https://gerrit.asterisk.org/4783
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0a5d56c7dcf327d60f86a4c25a23571733709fd0
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>



More information about the asterisk-code-review mailing list