[Asterisk-code-review] res pjsip pubsub.c: Implement "pjsip show subscriptions" com... (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Fri Jan 20 12:50:11 CST 2017


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4745 )

Change subject: res_pjsip_pubsub.c: Implement "pjsip show subscriptions" commands.
......................................................................


Patch Set 1:

There are three things I am aware of concerning subscriptions that relate to updating Asterisk level data structures.

1) The expiry value in the "pjsip show subscriptions" commands (ASTERISK-23828) currently count down to zero because the Asterisk level structures don't get updated with the new expiration time when the subscription is refreshed.

2) ASTERISK-26696 is the same as 1 but concerns the AstDB record.

3) Stopping Asterisk, rebooting phones, and then starting Asterisk will result in persisted subscriptions that haven't expired being recreated and not getting deleted when the old subscriptions expire because the phone created new subscriptions and no longer knows about the old ones.  However, the old subscriptions are removed the next time asterisk restarts.

These items are not addressed by this patch.  This patch just creates the new CLI commands.

-- 
To view, visit https://gerrit.asterisk.org/4745
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb8a3b61f447aedc58a8e6b36a810f7566018567
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list