[Asterisk-code-review] media: Add experimental support for RTCP feedback. (asterisk[master])

Lorenzo Miniero asteriskteam at digium.com
Fri Jan 20 11:19:11 CST 2017


Lorenzo Miniero has posted comments on this change. ( https://gerrit.asterisk.org/4614 )

Change subject: media: Add experimental support for RTCP feedback.
......................................................................


Patch Set 1:

Just as a comment, before merging you may want to hide the part that modifies the Speex bitrate according to the feedback behind a configuration option or something like this, so that only users interested in experimenting with it are affected. In fact, as explained the existing logic is very basic and untested, and only there as a placeholder example for more effective logics that may be implemented instead.

-- 
To view, visit https://gerrit.asterisk.org/4614
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd6aa77fb4a7ff546c6025900fc2baf332c31857
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Lorenzo Miniero <lminiero at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Lorenzo Miniero <lminiero at gmail.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list