[Asterisk-code-review] app queue: add RINGNOANSWER event on caller hang up (asterisk[master])

[Michael L. Young]

Michael L. Young has posted comments on this change. ( https://gerrit.asterisk.org/4649 )

Change subject: app_queue: add RINGNOANSWER event on caller hang up
......................................................................


Patch Set 2: Code-Review-1

I agree with Kevin.  This does not appear to be a desired change.

Besides the documentation, the name of the event RINGNOANSWER implies that the call was ringing an agent and they did not pick it up in a timely fashion - not that it was abandoned.  In looking at the code for rna(), it also follows that same thought pattern.

>From experience, we monitor this event to look for agents that potentially are allowing calls to ring on purpose until they time out so that it gets transferred to someone else.  This would raise false alerts and cause confusion unless handled properly looking for a related ABANDONED event.

I am not sure that you would want an agent attached to an ABANDONED event either.

It would seem that you need a new event named RINGCANCELED to handle the case where a call was sent to an agent, started to ring, but then was canceled before it could be answered.  That event could then contain the agent's name.

-- 
To view, visit https://gerrit.asterisk.org/4649
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic70f7b0f32fc95c9378e5bcf63865519014805d3
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-HasComments: No