[Asterisk-code-review] res pjsip WebRTC/websockets: Fix usage of WS vs WSS. (asterisk[14])

[Jørgen H]

Jørgen H has posted comments on this change. ( https://gerrit.asterisk.org/4972 )

Change subject: res_pjsip WebRTC/websockets: Fix usage of WS vs WSS.
......................................................................


Patch Set 5:

(1 comment)

This 8 year old patch by pjsip breaks ipv6 support with websockets: https://trac.pjsip.org/repos/changeset/2746

Commenting out their change in trunk/pjsip/src/pjsip/sip_util.c works for me with websockets, but havent tested the mentioned problem with udp and ipv6.
Asterisk will segfault if you dont comment out the pjsip-patch when connecting with websockets.

https://gerrit.asterisk.org/#/c/4972/4/res/res_pjsip_transport_websocket.c
File res/res_pjsip_transport_websocket.c:

Line 193: 	 */
Asterisk seems to ask for transport name WSS with this change.
However, the transport name is registered as WS down below in load_module()
The result is error messages like. create_out_of_dialog_request: Unable to create From header for OPTIONS request to endpoint


-- 
To view, visit https://gerrit.asterisk.org/4972
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a0fb1a41101a4c1e49d875a8aa87b189e7ab12
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jørgen H <asterisk.org at hovland.cx>
Gerrit-HasComments: Yes