[Asterisk-code-review] Add support Python 3 (testsuite[master])

Joshua Colp asteriskteam at digium.com
Mon Feb 27 16:53:21 CST 2017


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/4074 )

Change subject: Add support Python 3
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I'm working on testing this to see the impact. The full testsuite is still running but I'm adding a comment here with the one thing that stood out when I was looking at the execution.

https://gerrit.asterisk.org/#/c/4074/1/lib/python/asterisk/compat.py
File lib/python/asterisk/compat.py:

Line 47:         return d.iteritems(**kw)
This doesn't appear to work with the realtime module under Python 2:

exceptions.AttributeError: 'builtin_function_or_method' object has no attribute 'iteritems'

It may break other tests, mine is still running.


-- 
To view, visit https://gerrit.asterisk.org/4074
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58546fd8c0cff97f73aa1e80ebb85851102008fb
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list