[Asterisk-code-review] res pjsip WebRTC/websockets: Fix usage of WS vs WSS. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Mon Feb 27 13:00:38 CST 2017


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/4968 )

Change subject: res_pjsip WebRTC/websockets: Fix usage of WS vs WSS.
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4968/4/CHANGES
File CHANGES:

PS4, Line 98:  * Removed non-secure websocket support.  Firefox and Chrome have not allowed
            :    non-secure websockets for quite some time so this shouldn't be an issue
            :    for people.
Explain in more detail what this means for a user and the resulting behavior if they try to use it.


-- 
To view, visit https://gerrit.asterisk.org/4968
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a0fb1a41101a4c1e49d875a8aa87b189e7ab12
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Jørgen H <asterisk.org at hovland.cx>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list