[Asterisk-code-review] cli: Various fixes and improvements for CLI handling (asterisk[13])

[Sean Bright]

Hello Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/5087

to look at the new patch set (#2).

Change subject: cli: Various fixes and improvements for CLI handling
......................................................................

cli: Various fixes and improvements for CLI handling

This is a general cleanup of CLI and completion handling. Some of the
relevant highlights:

* Arguments that contain spaces can now be completed properly, whether
  they are quoted (e.g. 'queue show "<TAB>...') or backslash escaped
  (e.g. 'queue show Customer\ Support\ Que<TAB>').

* Because of the way completions are handled with the remote console,
  any completion option with spaces in it was treated as multiple
  completion options. This has been corrected.

* The local and remote console completion code calculated the number
  of matches differently, resulting in inconsistent sorting of options.

* The remote console would lock up if given a long input string to
  complete.

* Completion candidates were de-duplicated in multiple places, we now
  do it as early as possible before handing off to calling code.

* If we are only going to show a single line of completion options to
  the user, we no longer columnize the output.

Change-Id: Id911e1035525b33fc467e365a2cd6259aed1e90e
---
M include/asterisk/cli.h
M main/asterisk.c
M main/cli.c
3 files changed, 311 insertions(+), 109 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/87/5087/2
-- 
To view, visit https://gerrit.asterisk.org/5087
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id911e1035525b33fc467e365a2cd6259aed1e90e
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019