[Asterisk-code-review] Binaural synthesis (confbridge): DTMF conference management. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/3525 )

Change subject: Binaural synthesis (confbridge): DTMF conference management.
......................................................................


Patch Set 10: Code-Review-1

(4 comments)

Oops some things are missing.

https://gerrit.asterisk.org/#/c/3525/10/apps/confbridge/conf_config_parser.c
File apps/confbridge/conf_config_parser.c:

PS10, Line 426: 							<enum name="sound_muted"><para>The sound played when the mute option it toggled on.</para></enum>
              : 							<enum name="sound_unmuted"><para>The sound played when the mute option it toggled off.</para></enum>
sound_binaural_on/off are missing here.


PS10, Line 511: 						<enum name="toggle_mute"><para>
              : 							Toggle turning on and off mute.  Mute will make the user silent
              : 							to everyone else, but the user will still be able to listen in.
              : 							</para></enum>
Need a toggle_binaural added to the enum list documentation.


PS10, Line 1657: 	ast_cli(a->fd,"binaural_on:          %s\n", conf_get_sound(CONF_SOUND_BINAURAL_ON, b_profile.sounds));
               : 	ast_cli(a->fd,"binaural_off:         %s\n", conf_get_sound(CONF_SOUND_BINAURAL_OFF, b_profile.sounds));
sound_binarual_on/sound_binaurl_off like the rest of the output lines.


https://gerrit.asterisk.org/#/c/3525/10/configs/samples/confbridge.conf.sample
File configs/samples/confbridge.conf.sample:

PS10, Line 300: ; toggle_mute      ; Toggle turning on and off mute.  Mute will make the user silent
              :                    ; to everyone else, but the user will still be able to listen in.
Need a toggle_binaural description here.


-- 
To view, visit https://gerrit.asterisk.org/3525
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe708b9fe26097c1798fcbfcc4dc461267d8af8
Gerrit-PatchSet: 10
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Frank Haase <fra.haase at googlemail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Dennis Guse <dennis.guse at alumni.tu-berlin.de>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes