[Asterisk-code-review] SDP: Add initial SDP state machine. (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/5072 )

Change subject: SDP: Add initial SDP state machine.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5072/1/include/asterisk/sdp_state.h
File include/asterisk/sdp_state.h:

PS1, Line 70:  * The return here is const. The use case for this is so that a channel can add the SDP to an outgoing
            :  * message. The API user should not attempt to modify the SDP. SDP modification should only be done through
            :  * the API.
            :  */
            : void *ast_sdp_state_get_local(struct ast_sdp_state *sdp_state);
The documentation and actual return value do not match up. Sounds like in this case the return value should be "const void *"


-- 
To view, visit https://gerrit.asterisk.org/5072
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I871c0eb480b4c84d83e91ac5628e7a673e8b89ed
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes