[Asterisk-code-review] res config ldap: Various code improvements (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5065 )

Change subject: res_config_ldap: Various code improvements
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/5065/1/res/res_config_ldap.c
File res/res_config_ldap.c:

Line 1303: 			strlen(src->mod_values[0]) + strlen(new_value) + sizeof(";"));
> needs a "+ 1" in order to include the null terminator.
No, sizeof(";") is 2


-- 
To view, visit https://gerrit.asterisk.org/5065
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcfe404177cc6860ee5087976fe97812221b822
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes