[Asterisk-code-review] core: Show streams in "core show channel". (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5059 )

Change subject: core: Show streams in "core show channel".
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/5059/1/main/cli.c
File main/cli.c:

Line 1687: 		struct ast_stream *stream = ast_stream_topology_get_stream(ast_channel_get_stream_topology(chan), stream_num);
> Is there a threading concern here? It seems the underlying stream could be 
Nope! The channel lock protects the topology and streams inside. No changes can occur during this time and there is a guarantee that the stream is there.


-- 
To view, visit https://gerrit.asterisk.org/5059
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c95b57aa09415005f0677a1949a0feb07e4987a
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: Yes