[Asterisk-code-review] Add SDP translator and PJMEDIA implementation. (asterisk[master])

Mark Michelson asteriskteam at digium.com
Tue Feb 21 09:22:24 CST 2017


Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/4946 )

Change subject: Add SDP translator and PJMEDIA implementation.
......................................................................


Patch Set 5:

> I was more wondering from the perspective of using a memory pool
 > outside of a PJLIB registered thread, as it likes to get sad
 > because of that.

For chan_pjsip (and its constituent modules) this will not be an issue since SDP API calls will be happening from the session's serializer. If some theoretical PJMedia-using channel driver were to be added at some point, this could be a problem for it. However, I doubt such a channel driver would ever come into existence.

-- 
To view, visit https://gerrit.asterisk.org/4946
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2ecd3cbebe76756577be9b133e84d2ee356d46b
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list