[Asterisk-code-review] res pjsip: Fix segfault when status fails (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/4967 )

Change subject: res_pjsip: Fix segfault when status fails
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4967/1/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

Line 1239: 	if (!status) {
>From a user perspective I don't think returning -1 here is good. The Contact is present, we just don't have status. I think having the status be unknown in this case would be better.

A comment explaining why a status wouldn't be present would also be good.


-- 
To view, visit https://gerrit.asterisk.org/4967
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id52d3ca4d788562d236da49990a319118f8d22b5
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Jørgen H <asterisk.org at hovland.cx>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes