[Asterisk-code-review] res pjsip: Update authentication realm documentation. (asterisk[13])

George Joseph asteriskteam at digium.com
Sun Feb 19 18:01:48 CST 2017


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/4985 )

Change subject: res_pjsip: Update authentication realm documentation.
......................................................................


Patch Set 1:

> > Update samples?
 > 
 > No.  I had looked at doing that but there really wasn't anything to
 > update there.  The samples file isn't a full documentation place
 > for new modules.  The samples file just gives a brief summary.

Think like a user.  How many of then actually KNOW to type "config show help res_pjsip endpoint outbound_auth" or "config show help res_pjsip auth realm" to see the full help?  Not many.  And the wiki?  Good luck.

The first place people go is the samples config files.  You don't have to put the full description in the samples but the simple warning about not using the same auth for both inbound and outbound and a pointer to the wiki page with the realm description would at least tell someone that they need to look further.

-- 
To view, visit https://gerrit.asterisk.org/4985
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3952f7cfa1b6683b9954f2c5d2352d2f11059ce
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list