[Asterisk-code-review] Add SDP translator and PJMEDIA implementation. (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/4946 )

Change subject: Add SDP translator and PJMEDIA implementation.
......................................................................


Patch Set 4:

> Does the PJMEDIA translator run afoul of the threading boundary at
 > all for memory allocation?

On its own, possibly. If more than one translation is going on at once, then both threads will be accessing the same pool, and that would be bad. I'm not 100% sure how this would happen, though, but I don't want to rule it out entirely.

I'd like to make the translators themselves not have to worry about thread safety and leave that up to higher-level structures, such as the SDP state itself. This could stand to be documented better.

-- 
To view, visit https://gerrit.asterisk.org/4946
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2ecd3cbebe76756577be9b133e84d2ee356d46b
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No