[Asterisk-code-review] Add initial SDP options. (asterisk[master])

Mark Michelson asteriskteam at digium.com
Thu Feb 16 18:00:55 CST 2017


Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/4908 )

Change subject: Add initial SDP options.
......................................................................


Patch Set 7:

> I think we should still not use #ifdefs in that enum though and
 > make them truly static.

Weird. If you look at revision 5 I had removed the #ifdefs, but in revision 6 they came back somehow. Not sure how that happened.

-- 
To view, visit https://gerrit.asterisk.org/4908
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ede91aafed403b12a9ccdfb91a88389baa7e5d7
Gerrit-PatchSet: 7
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list