[Asterisk-code-review] res config sqlite3: Fix crash when loading with invalid config (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4957 )

Change subject: res_config_sqlite3: Fix crash when loading with invalid config
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4957/1/res/res_config_sqlite3.c
File res/res_config_sqlite3.c:

Line 1132: 		ast_config_destroy(config);
A special config pointer means that the config has to have been destroyed because the pointer cannot point to anything.  Besides CONFIG_STATUS_FILEMISSING is a NULL pointer.

As it is you are changing behavior by returning 1 here.  Before if the file was missing nothing was loaded and Asterisk carried on.  Now Asterisk will abort starting.  This is the same for CONFIG_STATUS_FILEINVALID.  You cannot correct the problem and manually load the module.


-- 
To view, visit https://gerrit.asterisk.org/4957
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6a5c0ca718ad428e01a1fb25beb209a9ac18bc6
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes