[Asterisk-code-review] res pjsip pubsub: Correctly implement persisted subscriptions (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Wed Feb 15 13:29:40 CST 2017


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4916 )

Change subject: res_pjsip_pubsub:  Correctly implement persisted subscriptions
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.asterisk.org/#/c/4916/8/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

PS8, Line 3660: 	ast_debug(3, "sub_tree %p sub_tree state %s\n", sub_tree,
              : 		(sub_tree ? sub_tree_state_description[sub_tree->state] : "UNKNOWN"));
> yes but pubsub on refresh timeout can be called directly and this one only 
So.  The next statement is a call to pubsub_on_refresh_timeout() which logs the same thing.  This is now just a wrapper for pubsub_on_refresh_timeout().


-- 
To view, visit https://gerrit.asterisk.org/4916
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c605fc1e3923f466a74db087d5ab6f90abce68e
Gerrit-PatchSet: 9
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list