[Asterisk-code-review] stream: Add unit tests for channel stream usage. (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/4947 )

Change subject: stream: Add unit tests for channel stream usage.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4947/2/tests/test_stream.c
File tests/test_stream.c:

PS2, Line 751: 	if (!ast_channel_get_stream_topology(mock_channel)) {
             : 		ast_test_status_update(test, "Set nativeformats with ulaw, alaw, and h264 on channel but it did not create a topology\n");
             : 		res = AST_TEST_FAIL;
             : 	} else if (ast_stream_topology_get_count(ast_channel_get_stream_topology(mock_channel)) != 2) {
             : 		ast_test_status_update(test, "Set nativeformats on a channel to ulaw, alaw, and h264 and received '%d' streams instead of expected 2\n",
             : 			ast_stream_topology_get_count(ast_channel_get_stream_topology(mock_channel)));
             : 		res = AST_TEST_FAIL;
             : 	}
I think this should explore the created topology a bit more. Ensure that the types of streams are correct, that they're in the preferred order, and that the formats on each stream are what we would expect them to be.


-- 
To view, visit https://gerrit.asterisk.org/4947
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic53176dd3e4532e8c3e97d9e22f8a4b66a2bb755
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes