[Asterisk-code-review] Add initial SDP options. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/4908 )

Change subject: Add initial SDP options.
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/4908/4/include/asterisk/sdp_options.h
File include/asterisk/sdp_options.h:

PS4, Line 106: enum ast_sdp_options_repr {
             : 	/*! SDP is represented as a string */
             : 	AST_SDP_REPR_STRING = 0,
             : 	/*! SDP is represented as a pjmedia_sdp_session */
             : 	AST_SDP_REPR_PJMEDIA,
             : };
> Should this be more dynamic? For instance, what happens if a third party mo
I think if we find ourselves needing to be dynamic in the future we can extend the API to allow it (have a fixed range for dynamic and a dynamic registration/query mechanism). I think fixed will work fine for most cases.


-- 
To view, visit https://gerrit.asterisk.org/4908
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ede91aafed403b12a9ccdfb91a88389baa7e5d7
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes