[Asterisk-code-review] pjsip distributor.c: Fix off-nominal tdata ref leak. (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Tue Feb 14 12:41:29 CST 2017


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4924 )

Change subject: pjsip_distributor.c: Fix off-nominal tdata ref leak.
......................................................................


Patch Set 1:

> So, it's a theoretical?
 > 
 > The return value should match an enum, if not then they are
 > violating the contract.

Should still code for that path.  This patch make sure and we won't wind up with dead code to satisfy the compiler.

-- 
To view, visit https://gerrit.asterisk.org/4924
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I571f371d0956a8039b197b4dbd8af6b18843598d
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list