[Asterisk-code-review] stream: Add stream topology to channel (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/4939 )

Change subject: stream:  Add stream topology to channel
......................................................................


Patch Set 5:

(4 comments)

https://gerrit.asterisk.org/#/c/4939/5/main/channel_internal_api.c
File main/channel_internal_api.c:

Line 838: 			ast_stream_topology_get_first_stream_by_type(chan->stream_topology, type);
This also needs to be added to the masquerade code so that the topology and default streams get moved


Line 843: 	struct ast_format_cap *value)
This function can be called with a NULL value, in this case the existing topology (and default streams) should go away


Line 852: 	if (chan->tech->properties & AST_CHAN_TP_MULTISTREAM) {
Only if the flag is NOT set does the core need to create streams for the channel.


Line 854: 		chan->stream_topology = ast_stream_topology_create_from_format_cap(value);
The topology needs to be destroyed when the channel is destroyed


-- 
To view, visit https://gerrit.asterisk.org/4939
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic379ea82a9486fc79dbd8c4d95c29fa3b46424f4
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes