[Asterisk-code-review] res pjsip pubsub: Correctly implement persisted subscriptions (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/4916 )

Change subject: res_pjsip_pubsub:  Correctly implement persisted subscriptions
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.asterisk.org/#/c/4916/2/res/res_pjsip_exten_state.c
File res/res_pjsip_exten_state.c:

Line 358: 		ast_log(LOG_NOTICE, "Extension state subscription failed from '%s': "
> Endpoint '%s' extension state subscription failed: ...
Done


https://gerrit.asterisk.org/#/c/4916/2/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

Line 3571: 	ast_debug(3, "evsub %p state %s event %s sub_tree %p sub_tree state %s\n", evsub,
> Not sure about this debug message.  It is just listing off variables with l
What more context do you need?  You already know what function it's in and you already know that this function gets called in many circumstances.  Knowing what circumstances is a big help.


Line 3572: 		pjsip_evsub_get_state_name(evsub), pjsip_event_str(event->type), sub_tree,
> sub_tree being NULL will cause a crash on solaris.
Done


Line 3619: 		ast_log(LOG_ERROR, "Possible terminate race prevented %p %d\n", sub_tree->evsub, sub_tree->state);
> Promoting debug to ERROR?
Oops, forget to set this back.


-- 
To view, visit https://gerrit.asterisk.org/4916
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c605fc1e3923f466a74db087d5ab6f90abce68e
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes