[Asterisk-code-review] stream: Add stream topology to channel (asterisk[master])

Joshua Colp asteriskteam at digium.com
Mon Feb 13 12:03:58 CST 2017


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/4939 )

Change subject: stream:  Add stream topology to channel
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/4939/2/include/asterisk/stream.h
File include/asterisk/stream.h:

Line 146:  * \param type The new media type
This move doesn't seem right.


https://gerrit.asterisk.org/#/c/4939/2/main/channel_internal_api.c
File main/channel_internal_api.c:

Line 836: 	for(type = AST_MEDIA_TYPE_UNKNOWN; type < AST_MEDIA_TYPE_END; type++) {
Space between for and (


-- 
To view, visit https://gerrit.asterisk.org/4939
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic379ea82a9486fc79dbd8c4d95c29fa3b46424f4
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list