[Asterisk-code-review] Add initial SDP options. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/4908 )

Change subject: Add initial SDP options.
......................................................................


Patch Set 3: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/4908/3/include/asterisk/sdp_options.h
File include/asterisk/sdp_options.h:

Line 57: 	AST_SDP_ICE_DISABLED,
Might want to anchor the enums by adding '= 0' to the first entry.


Line 108: 	AST_SDP_REPR_STRING,
anchor


Line 135: 	AST_SDP_ENCRYPTION_DISABLED,
anchor


https://gerrit.asterisk.org/#/c/4908/3/main/sdp_options.c
File main/sdp_options.c:

Line 63: 	options->ice = ice_setting;
ast_assert for NULL checking?


-- 
To view, visit https://gerrit.asterisk.org/4908
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ede91aafed403b12a9ccdfb91a88389baa7e5d7
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes