[Asterisk-code-review] manager: Restore Originate failure behavior from Asterisk 11 (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4913 )

Change subject: manager: Restore Originate failure behavior from Asterisk 11
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Minor tweaks.  Looks fine otherwise.

https://gerrit.asterisk.org/#/c/4913/2/include/asterisk/pbx.h
File include/asterisk/pbx.h:

PS2, Line 1134: 	AST_OUTGOING_NO_WAIT = 0,       /*! Don't wait for originated call to answer */
              : 	AST_OUTGOING_WAIT = 1,          /*! Wait for originated call to answer */
              : 	AST_OUTGOING_WAIT_COMPLETE = 2, /*! Wait for originated call to answer and hangup */
              : }
To use end comments with doxygen:
foo; /*!< bar comment */


PS2, Line 1152:  * \param synchronous defined by the ast_pbx_outgoing_sync enum. If zero then don't
              :  *        wait for anything. If one then block until the outbound channel answers
              :  *        or the call fails. If greater than one then wait for the call to complete
              :  *        or if the call doesn't answer and failed at context exists then run a
              :  *        channel named OutgoingSpoolFailed at failed at context.
The comment about when failed at context is executed needs to apply to 1 <= synchronous.  As it was described it only applies to 2 == synchronous.


-- 
To view, visit https://gerrit.asterisk.org/4913
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8afbd06725e99610e02adb529137d4800c05345d
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes