[Asterisk-code-review] res stasis device state: Protect the adding/removing of subs... (asterisk[13])

Kevin Harwell asteriskteam at digium.com
Tue Feb 7 10:51:18 CST 2017


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/4890 )

Change subject: res_stasis_device_state: Protect the adding/removing of subscriptions.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/4890/2/res/res_stasis_device_state.c
File res/res_stasis_device_state.c:

PS2, Line 409: 	sub = find_device_state_subscription(app, name);
             : 	remove_device_state_subscription(sub);
I know it wasn't there before, but can sub be NULL here? If so, might want to check for it


-- 
To view, visit https://gerrit.asterisk.org/4890
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e7f8eb9d09de440c9024d2dd52029f6f20e725b
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list