[Asterisk-code-review] res stasis device state: Protect the adding/removing of subs... (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/4890 )

Change subject: res_stasis_device_state: Protect the adding/removing of subscriptions.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4890/1/res/res_stasis_device_state.c
File res/res_stasis_device_state.c:

Line 369: 	if (is_subscribed_device_state(app, sub->device_name)) {
is_subscribed_device_state is also called from the stasis_app_event_source callback object.

When called from the callback object it would call find_device_state_subscription without locking device_state_subscriptions, which then in turn calls ao2_find with OBJ_NOLOCK.


-- 
To view, visit https://gerrit.asterisk.org/4890
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e7f8eb9d09de440c9024d2dd52029f6f20e725b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes