[Asterisk-code-review] Frame deferral: Will this be the last rework on it? (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4771 )

Change subject: Frame deferral: Will this be the last rework on it?
......................................................................


Patch Set 2:

This works but there are 20 testsuite tests that hit the assertion in ast_channel_start_defer_frames() because of the bad implementation of AMI PlayDTMF action.  (ASTERISK-25940)

I am abandoning this review in favor of a patch series.
1) Revert the frame deferral API
2) Redo the AGI eating frames issue.
3) and fixing the alert-pipe imbalance created in __ast_queue_frame().

I updated the review with the fixes for the async-goto issue the ConfBridge testsuite tests found so there is a way to recover these changes if the deferral API is resurected.

-- 
To view, visit https://gerrit.asterisk.org/4771
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8383a8b23ba9a335c138a9c0e79fca24b78343c
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No