[Asterisk-code-review] cdr: Missing NULL check and unlock. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Mon Dec 25 20:38:16 CST 2017


Hello Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/7738

to look at the new patch set (#2).

Change subject: cdr: Missing NULL check and unlock.
......................................................................

cdr: Missing NULL check and unlock.

* handle_dial_message: Missing a check for NULL peer.
* cdr_generic_register: Missing unlock on allocation failure.

cdr_generic_register is fixed by reordering so the new structure is
allocated and initialized before locking the list.

Change-Id: I5799b99270d1a7a716a555c31ac85f4b00ce8686
---
M main/cdr.c
1 file changed, 25 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/38/7738/2
-- 
To view, visit https://gerrit.asterisk.org/7738
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5799b99270d1a7a716a555c31ac85f4b00ce8686
Gerrit-Change-Number: 7738
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171225/c27b13e6/attachment.html>


More information about the asterisk-code-review mailing list