[Asterisk-code-review] SDP: Rework SDP offer/answer model and update capabilities m... (asterisk[15])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7670 )

Change subject: SDP: Rework SDP offer/answer model and update capabilities merges.
......................................................................


Patch Set 1: Code-Review-1

I'm -1 on this patch series.  If it's OK to break these API's because they're unused I'd prefer we just remove them.  I don't want us to get in a habit of saying "well that API is unused so it's ok to break it".  Removal would be a one-time breakage, we wouldn't be making the exception next time master does something (this is still a new API, it's reasonable to expect changes).

>From IRC last night:
<rmudgett> https://gerrit.asterisk.org/#/c/7670/ to https://gerrit.asterisk.org/#/c/7672/ are to bring v15 up to master where the new SDP code is concerned.
<rmudgett> Though that code is effectively dead code since nothing uses it yet.
<rmudgett> file: coreyfarrell gtjoseph ^^^
<gtjoseph> ok
<gtjoseph> i'm unsure of the implications.
<gtjoseph> or whether there is an action item for me
<rmudgett> Well they are reviews and this just keeps the master and v15 in sync to prevent unnecessary divergence.
<gtjoseph> Oh, OK.
<rmudgett> Otherwise, I think the new SDP code should be removed from v15.
<coreyfarrell> rmudgett: I assume you are aware of the ABI/API changes?  if it's dead-code and we're OK with pulling it from an ABI/API standpoint I think that might be best.
<rmudgett> Yep.  Nothing uses it yet so there isn't an API/ABI problem.
<coreyfarrell> my vote is to remove it from 15.  if a few months from now we want it in 15 we can bring it back but more likely it'll be for Asterisk 16 and we'll avoid the work of keeping it in sync.


-- 
To view, visit https://gerrit.asterisk.org/7670
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: If07fe6d79fbdce33968a9401d41d908385043a06
Gerrit-Change-Number: 7670
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Wed, 20 Dec 2017 16:57:42 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171220/b8a458a9/attachment.html>