[Asterisk-code-review] CLI: Address multiple issues. (asterisk[master])
Corey Farrell
asteriskteam at digium.com
Tue Dec 19 13:08:19 CST 2017
Hello Jenkins2,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/7661
to look at the new patch set (#2).
Change subject: CLI: Address multiple issues.
......................................................................
CLI: Address multiple issues.
* listen uses the variable `s` for the result from ast_poll() then
overwrites it with the result of accept(). Create a separate variable
poll_result to avoid confusion since ast_poll does not return a file
descriptor.
* Reserve an extra byte while processing completion results from remote
daemon. This fixes a bug where completion processing used strstr() on
a string that was not '\0' terminated. This was no risk to the Asterisk
daemon, the bug was only reachable the remote console process.
* Resolve leak in handle_showchan when the channel is not found.
* Multiple leaks in pbx_config CLI completion.
* Fix leaks in "manager show command".
Change-Id: I8f633ceb1714867ae30ef4e421858f77c14485a9
---
M main/asterisk.c
M main/cli.c
M main/manager.c
M pbx/pbx_config.c
4 files changed, 37 insertions(+), 27 deletions(-)
git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/61/7661/2
--
To view, visit https://gerrit.asterisk.org/7661
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f633ceb1714867ae30ef4e421858f77c14485a9
Gerrit-Change-Number: 7661
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171219/0693b7c2/attachment.html>
More information about the asterisk-code-review
mailing list