[Asterisk-code-review] CLI: Address multiple issues. (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/7663 )

Change subject: CLI: Address multiple issues.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/7663/1/main/cli.c
File main/cli.c:

https://gerrit.asterisk.org/#/c/7663/1/main/cli.c@1525
PS1, Line 1525: 	output = ast_str_create(8192);
              : 	if (!output) {
              : 		return CLI_FAILURE;
              : 	}
> Then I'd have to release the channel in this error block.
Right, but a channel not found is a much more likely scenario than an allocation failure and as it is we're potentially allocating 8k for no reason.



-- 
To view, visit https://gerrit.asterisk.org/7663
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f633ceb1714867ae30ef4e421858f77c14485a9
Gerrit-Change-Number: 7663
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 19 Dec 2017 19:02:27 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171219/1b1b2996/attachment.html>