[Asterisk-code-review] ast json pack(): Use safer json ref mechanism. (asterisk[master])

Jenkins2 asteriskteam at digium.com
Tue Dec 19 10:23:42 CST 2017


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/7635 )

Change subject: ast_json_pack(): Use safer json ref mechanism.
......................................................................

ast_json_pack(): Use safer json ref mechanism.

Change-Id: I49204db2e57ae96eee43909c18ed007c09ac817e
---
M main/cel.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Corey Farrell: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/main/cel.c b/main/cel.c
index cec0a85..24a35be 100644
--- a/main/cel.c
+++ b/main/cel.c
@@ -1835,9 +1835,9 @@
 	struct ast_json *cel_blob;
 	struct stasis_message *message;
 
-	cel_blob = ast_json_pack("{s: i, s: O}",
+	cel_blob = ast_json_pack("{s: i, s: o}",
 		"event_type", event_type,
-		"event_details", blob);
+		"event_details", ast_json_ref(blob));
 
 	message = ast_channel_blob_create_from_cache(ast_channel_uniqueid(chan), cel_generic_type(), cel_blob);
 	if (message) {

-- 
To view, visit https://gerrit.asterisk.org/7635
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I49204db2e57ae96eee43909c18ed007c09ac817e
Gerrit-Change-Number: 7635
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171219/ec014100/attachment.html>


More information about the asterisk-code-review mailing list